Improve Name And Implementation Of `enhanceElementsImages` · guardian/dotcom-rendering

(0 条评论) (0 个反应) (0 位负责人)TypeScript (35 个派生)auto 404

Pick me upTeam Candidate: WebXgood first issue

仓库指标

星标: (271 个星标)
PR 合并指标: (PR 指标待抓取)

描述

https://github.com/guardian/dotcom-rendering/blob/5916d46b86dfefbf2a817c93d207516fd114533d/dotcom-rendering/src/model/enhance-images.ts#L448-L457

The name is unclear, perhaps it should be enhanceMainMediaImages.
Why does isPhotoEssay include a check for labs? And why is it different to: https://github.com/guardian/dotcom-rendering/blob/5916d46b86dfefbf2a817c93d207516fd114533d/dotcom-rendering/src/model/enhance-images.ts#L432-L435

贡献者指南

研究方向: 检查enhance images.ts中引用的代码行，理解当前命名和逻辑。探究为什么`isPhotoEssay`包含对labs的检查以及它与另一个函数的不同之处。建议重命名并统一逻辑。
技术栈: typescript
领域: frontend
议题类型: 重构
难度: 2
预计时间: 1-3 小时
活动状态: 新近可参与
清晰度: 基本清晰
前置要求: TypeScriptGit
新手友好度: 80