grpc/grpc-java

Recommended IntelliJ code style settings are out of date

Open

#617 创建于 2015年7月10日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Java (11,124 star) (3,742 fork)batch import
help wanted

描述

I downloaded and imported the GoogleStyle code style settings xml, as recommended in Contributing.md. It doesn't seem like this project and its checkstyle are actually conforming to those style settings (which is fine, I like the prevailing gRPC style better!) A few things in particular keep coming up:

  • Import order: GoogleStyle has static imports at the bottom, doesn't separate grpc imports. This is configured in Code Style > Java > Imports > Import Layout.
  • Method argument wrapping: GoogleStyle has method call arguments and declaration parameters on the next line aligned to the opening paren. This is configured in Code Style > Java > Wrapping and Braces > Method declaration parameters > Align when multiline, as well as the same option under Method call arguments.

贡献者指南

技术栈
java
领域
developer experience
议题类型
chore
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
IntelliJ IDEABasic knowledge of Java code style
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Update the IntelliJ code style settings XML file to match the project's actual style, particularly import order and method argument wrapping. Also update the Contributing.md to reflect the current recommended settings. Refer to the existing checkstyle configuration for guidance.