grpc/grpc-java

Verify server sends grpc-accept-encoding appropriately

Open

#1,804 创建于 2016年5月6日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Java (11,124 star) (3,742 fork)batch import
help wanted

描述

If the client sends a gzip-encoded request and the server responds with headers (endStream=false) that does not include grpc-accept-encoding gzip, then the client should warn. This is misbehavior on the server-side and would ideally be detected.

Although I said "warn" above, we're actually aware of servers failing to do this properly today. So initially we can use FINE and eventually swap it to warn.

贡献者指南

技术栈
javagrpc
领域
backendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavagRPC basicsHTTP/2 knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the client side code in grpc java where headers are received, specifically in classes like ClientCallImpl or similar. Look for where response headers are processed and find where grpc accept encoding should be checked. Review the existing logic for handling gzip encoding and implement a log warning at FINE level if the header is missing, as discussed in the issue comments.
Verify server sends grpc-accept-encoding appropriately · grpc/grpc-java#1804 | Good First Issue