grpc/grpc-java

Support --incompatible_enable_proto_toolchain_resolution

Open

#11,152 创建于 2024年5月6日

在 GitHub 查看
 (8 评论) (4 反应) (0 负责人)Java (11,124 star) (3,742 fork)batch import
Waiting on reporterenhancementhelp wanted

描述

Is your feature request related to a problem?

The problem is need to compile protoc instead of using prebuilt binary while building java_grpc_library

Describe the solution you'd like

Support --incompatible_enable_proto_toolchain_resolution bazel flag so users can override protoc compiled from sources with prebuilt binary, as already done in rules_python or WIP in rules_go

Describe alternatives you've considered

Additional context

Examples of declarations toolchains for other languages that already support the feature here

贡献者指南

技术栈
java
领域
build systembackend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
BazelJavagRPCProtobuf toolchains
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Study the referenced PRs in rules python and rules go to understand the pattern for supporting incompatible enable proto toolchain resolution. Examine the example toolchain declarations in aspect build/toolchains protoc. Then implement similar toolchain registration in grpc java's Bazel build files, likely in the grpc java repository's BUILD files or proto rules. Coordinate with maintainers to ensure compatibility.