grpc-ecosystem/grpc-gateway

Possible regression when specifying duplicate paths

Open

#830 创建于 2018年12月12日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)Go (16,971 star) (2,250 fork)batch import
bughelp wanted

描述

I haven't got a lot of time to debug this right now, but at work I've recently run into several instances of the generator not erroring when specifying duplicate paths, like so:

get: "/api/v1/users/{user_id}"
...
get: "/api/v1/users/things"

The second one should not be allowed because it is ambiguous with the first one. I'm pretty sure this used to work, so I assume it's a regression. I'm raising just so I don't forget about it. This is happening on latest master.

贡献者指南

技术栈
gogrpcrest api
领域
backendapitooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programminggRPC basicsgrpc gateway codebase structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
The issue is a regression: duplicate paths should trigger an error but do not. Examine the generator's route validation logic, likely in the `internal/descriptor` or `protoc gen grpc gateway` packages. Look for recent commits that might have removed the duplicate path check. Check the test files for any existing tests for duplicate paths. The maintainers may need to confirm the expected behavior.
Possible regression when specifying duplicate paths · grpc-ecosystem/grpc-gateway#830 | Good First Issue