grommet/grommet

Anchor - icon size

Open

#7,231 创建于 2024年5月14日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (8,247 star) (1,015 fork)batch import
bughacktoberfesthelp wanted

描述

Expected Behavior

If the icon is not passed a size then the icon size should scale based on the Anchor size. Potentially related to the useSizedIcon function in Grommet.

Actual Behavior

The icon size does not scale with the Anchor size.

URL, screen shot, or Codepen exhibiting the issue

image

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
React basicsGrommet component structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the Anchor component source code in the Grommet repository, focusing on how icon size is currently handled and how the `useSizedIcon` function works. Check if there is a size prop inheritance mechanism from Anchor to its icon. The issue mentions that icon size should scale based on Anchor size when no icon size is specified. Look at the Anchor component file (likely in src/js/components/Anchor) and the useSizedIcon hook to understand the current logic and identify where the scaling behavior is missing.