graphql-python/graphene-django

GraphQLView should detect batch requests

Open

#967 创建于 2020年5月21日

在 GitHub 查看
 (7 评论) (1 反应) (0 负责人)Python (4,173 star) (754 fork)batch import
help wanted✨enhancement

描述

Is there a valid reason why the GraphQLView input is validated to either only ever accept batched requests or never accept batched requests. Is it not reasonable to accept both?

https://github.com/graphql-python/graphene-django/blob/ee120c48e16dda818cb253fdc36b7053402956b0/graphene_django/views.py#L217

贡献者指南

技术栈
pythondjangographql
领域
backendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic Django knowledgeGraphQL basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue requests modifying the GraphQLView in graphene django/views.py to detect and accept both batched and single GraphQL requests. The relevant code is at line 217 (linked in the issue). Currently, the view validates the input to expect either a list or a single object, but not both. A first time contributor should examine the parse body or dispatch method to implement logic that checks the request body type (list or dict) and processes accordingly. The goal is to allow a client to send either format without breaking existing functionality.
GraphQLView should detect batch requests · graphql-python/graphene-django#967 | Good First Issue