grafana/pyroscope

Make all inputs have white background when they are editable

Open

#1,642 创建于 2022年10月26日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C (9,041 star) (528 fork)batch import
frontendgood first issue

描述

One needs to go over every single input and make sure it has a white background if it's editable. Example: image

Here's an example of annotations, that does it correctly: timestamp field has a dark background because it's read only. image

Ideally the solution would work out of the box for all inputs.

贡献者指南

技术栈
无
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The fix requires identifying all input elements in the frontend and applying a global CSS rule such as `input:not([readonly]) { background color: white; }`. Look for existing CSS files in the repository, possibly in a `styles` or `components` directory. Ensure that readonly inputs retain their current background color.
Make all inputs have white background when they are editable · grafana/pyroscope#1642 | Good First Issue