grafana/k6

Move Sobek option parsing to the mapping layer

Open

#5,305 创建于 2025年10月14日

在 GitHub 查看
 (22 评论) (0 反应) (1 负责人)Go (30,564 star) (1,537 fork)batch import
area: browsergood first issuerefactor

描述

What

  • Move Sobek option parsing to the mapping layer.

Why

  • Separation of concerns.
  • Option parsing is only required by the mapping layer.
  • To simplify and make the code and tests easy to reason about.

Current options to move

  • Frame options
  • Locator options
  • ElementHandleBaseOptions
  • #5687
  • PageReloadOptions
  • PageScreenshotOptions
  • Size.Parse
  • #5302
  • #5560

Example

  • In this code, the parsing happens in the mapping layer.

Related

  • This issue is a continuation of the epic issue #4219.

贡献者指南

技术栈
go
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingk6 codebase structureSobek API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine the existing mapping layer in files like locator mapping.go and browser mapping.go to understand the current pattern. Review the list of options to be moved, noting that some are already completed (e.g., #5687, #5302, #5560). Discuss with the assignee to coordinate work. Ensure each option is moved following the separation of concerns principle, with updated tests.