grafana/k6

webcrypto: Throw exception on `saltLength: 0` for RSA PSS sign/verify

Open

#4,265 创建于 2024年10月30日

在 GitHub 查看
 (14 评论) (0 反应) (1 负责人)Go (30,564 star) (1,537 fork)batch import
area: webcryptogood first issuehelp wanted

描述

What?

While implementing support of RSA grafana/xk6-webcrypto#85 we've found that standard Golang's SDK doesn't provide support of the saltLength: 0, instead it always tries to generate salt with the maximum length.

This led us for the patch to WebPlatfrom tests: https://github.com/grafana/xk6-webcrypto/blob/main/webcrypto/tests/wpt-patches/WebCryptoAPI__sign_verify__rsa.js.patch

Since some use cases could actually try to use the lengths of salt 0 we need to issue a log warning user that the actual behavior of our implementation is different.

edit(@mstoykov): After some discussion the idea is currently to throw an exception instead of just log a warning.

Why?

It improves UX and makes implementation predictable.

贡献者指南

技术栈
gojavascript
领域
backendsecurity
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
GoWebCrypto APIRSA PSS
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue requires modifying the RSA PSS sign/verify implementation in Go to throw an exception when saltLength is 0. Review the discussion in the issue comments, especially the linked patch in xk6 webcrypto repository. The change should be in the file handling WebCrypto operations, likely in the xk6 webcrypto submodule or a similar location. Ensure the exception matches the WebCrypto specification.