grafana/k6

Address jhump/protoreflect deprecations introduced by v1.17.0

Open

#4,035 创建于 2024年11月4日

在 GitHub 查看
 (4 评论) (0 反应) (1 负责人)Go (30,564 star) (1,537 fork)batch import
enhancementgood first issue

描述

As we bumped our github.com/jhump/protoreflect/desc dependency to v0.17.0 we decided to postpone addressing the deprecations this specific version introduced.

Specifically:

  • github.com/jhump/protoreflect/desc is now considered deprecated.

This package is now deprecated. Though use of this package is still needed in order to use a handful of other packages in this repo, many usages should instead prefer the "google.golang.org/protobuf/reflect/protoreflect" package in the Protobuf runtime. In a v2 of this repo, this package will no longer be present.

  • github.com/jhump/protoreflect/desc/protoparse is now considered deprecated.

This package is now deprecated. Most usages should instead prefer the "github.com/bufbuild/protocompile" package. There are some behavioral differences that we hope to address with additional API and enhancements to protocompile. But the protoparse package here is just a veneer on top of protocompile and we plan to do as little maintenance as possible here. In a v2 of this repo, this package will no longer be present.

As a result we have a couple of //nolint:staticcheck comments ignoring those deprecations explicitly. Those can be found in the following files:

Definition of done

We have replaced the deprecated packages import with their more modern counterparts, and the nolint statements have been removed.

贡献者指南

技术栈
go
领域
backendtestingperformance
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingprotobuf basicsk6 codebase familiarity
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue involves replacing deprecated packages from jhump/protoreflect with their modern counterparts (google.golang.org/protobuf and bufbuild/protocompile). The specific files requiring changes are listed: lib/netext/grpcext/reflect.go, lib/netext/grpcext/conn test.go, and js/modules/k6/grpc/client.go (appears twice). The maintainer should first review the updated dependency's documentation and the linked release notes to understand the new APIs. Then, systematically replace each import and adjust usage accordingly. Finally, remove the //nolint:staticcheck comments. Testing is crucial to ensure functionality remains intact.
Address jhump/protoreflect deprecations introduced by v1.17.0 · grafana/k6#4035 | Good First Issue