grafana/k6

Run tests in separate process so that we actually test loading proto definitions at runtime

Open

#3,552 创建于 2023年7月5日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Go (30,564 star) (1,537 fork)batch import
area: grpccihelp wantedtests

描述

Originally raised in this comment by @thiagodpf.

What?

The current unit tests run the server and clients in the same process.

gRPC seems to have a global registry for types, so once the server loads them, the client doesn't need to.

This means that all tests that test that clients actually manage to load types correctly only with .proto files are not actually testing that :(

Solutions:

Preferably go test ./... should run the unit tests with the server and client as separate process - preferably even separate from the main go test one :thinking:

This sounds involved.

A quicker solution will be to have another CI step that runs a server + k6 run script.js exercising the most common cases.

Both will be best.

贡献者指南

技术栈
gojavascript
领域
testing
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Go programmingtesting experiencegRPC basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the current test structure in the k6 repository, particularly around gRPC tests. The issue references a comment in issue #3160. Consider implementing a CI step that runs a server and executes 'k6 run script.js' to test proto loading, or refactor unit tests to use separate processes. Review the existing test files for gRPC and the CI configuration (e.g., GitHub Actions workflows) to determine the best approach.