googlefonts/glyphsLib

Handle default layer with custom name

开放

#619 创建于 2020年8月17日

 (0 条评论) (1 个反应) (0 位负责人)Python (55 个派生)github user discovery
enhancementhelp wanted

仓库指标

星标
 (198 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

https://unifiedfontobject.org/versions/ufo3/layercontents.plist/ says:

public.default

This layer name indicates that the default layer has no user defined name. It must not be used as the layer name for any directory other than the default glyphs directory.

GlyphLib assumes the default layer has no user defined name but that may not be the case. https://github.com/googlefonts/glyphsLib/blob/638cbddd00b2334410bab914d932bf673d6342ca/Lib/glyphsLib/builder/layers.py#L74 Instead it should check that the layer is font.layers.defaultLayer or that its name is font.layers.defaultLayer.name.

贡献者指南