google/open-location-code

Update JSON file access by karma/jasmine tests

Open

#324 创建于 2019年5月3日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Java (3,945 star) (500 fork)batch import
help wantedjs

描述

Existing node JS tests (in js/test) use a combination of gulp and phantomjs to run.

phantomjs is now unsupported (and seems to be a pain to get working locally) so it would be good to refactor the tests to use karma/jasmine.

I've had a quick go at this but got stuck trying to get the test functions to access the CSV files. (If we have to we could convert them to JSON as part of the test script.)

贡献者指南

技术栈
javascriptnodejs
领域
developer experience
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaScript testing experienceFamiliarity with Karma/JasmineFile I/O in Node
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Review the current test setup in `js/test` to understand how gulp and phantomjs are used. Examine the test functions that need to access CSV files and determine the best way to either allow direct file access in karma/jasmine or convert the CSV files to JSON format. Look for any related comments in the issue for guidance from maintainers.