google/leveldb

Make background thread stoppable

Open

#863 创建于 2020年12月18日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)C++ (39,075 star) (8,199 fork)batch import
enhancementhelp wanted

描述

Hi,

Current version of LevelDB has detached background thread that can't be stopped and each environment calls std::abort() in destructor. This behavior prevents using of LevelDB in plugin dlls that can be started and stopped when main application still runs.

I think it is better to allow background thread to finish tasks in queue and then exit, when environment is being destroyed. That will make database loadable and unloadable.

贡献者指南

技术栈
cpp
领域
database
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++ threadingLevelDB environment API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the current environment destructor and background thread implementation in LevelDB. Look at files such as util/env posix.cc and include/leveldb/env.h to understand how the background thread is created and managed. Identify where std::abort() is called and design a mechanism to allow the thread to finish its current tasks and exit gracefully when the environment is destroyed. Review any existing discussions in the issue comments for additional insights or constraints.