google/gvisor

[checklocks]: source file and line number sometimes not printed

Open

#11,203 创建于 2024年11月21日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)Go (12,713 star) (1,061 fork)batch import
good first issuestatus: help wantedtype: bug

描述

Description

sometimes I see:

-: return with unexpected locks held (locks: &({param:f}.mu) exclusively)

notice the usual file name and line number is replaced by -.

Steps to reproduce

go: downloading gvisor.dev/gvisor v0.0.0-20241120231458-0add1d20fa0c

I haven't been able to extract a simple repro (the fact that I can't tell where the error is happening makes it harder). I happen to believe these are false positive as well but it's hard to prove without knowing what it's unhappy about :-)

runsc version

docker version (if using docker)

uname

No response

kubectl (if using Kubernetes)

repo state (if built from source)

No response

runsc debug logs (if available)

贡献者指南

技术栈
go
领域
backendtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
over 1 week
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
Go programmingconcurrency conceptsgvisor internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Investigate the checklocks code in gvisor to find where error messages are constructed. The file and line number appear as ' ' so look for cases where file/line information is missing or overridden. Check the logic that determines whether to include file/line in the error string. Consider adding logging or debug output to capture the stack trace when the error occurs.