google/googletest

[Bug]: CMake FetchContent_* does not work with GTest as dependency name on Windows

Open

#4,384 创建于 2023年10月3日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)C++ (38,603 star) (10,772 fork)batch import
help wanted

描述

Describe the issue

CMake FetchContent_* does not work with GTest as dependency name. If the dependency name is changed to googletest or to foobar everything works as expected. This is very unfortunate because GTets is used in the find_package command of CMake and if this fails the FetchContent mechanism can be used as fallback. But not on windows as you can see here:

https://github.com/ObiWahn/googletest-CMake-FetchContent/pull/1

Steps to reproduce the problem

https://github.com/ObiWahn/googletest-CMake-FetchContent/pull/1/files

What version of GoogleTest are you using?

v.1.14.0

What operating system and version are you using?

windows

What compiler and version are you using?

msvc / clang

What build system are you using?

cmake 3.27.6

Additional context

No response

贡献者指南

技术栈
cpp
领域
build system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
CMakeFetchContentWindows build tools
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the issue reported in googletest issue #4384 and the related temporary PR at https://github.com/ObiWahn/googletest CMake FetchContent/pull/1. The problem occurs when using CMake's FetchContent with the dependency named 'GTest' on Windows. Review the CMake modules in the googletest repository, particularly the handling of find package and FetchContent integration, to understand why certain names cause failures. The fix may involve renaming or adding logic to handle the 'GTest' name collision.