google/comprehensive-rust

Explicitly call out dev-dependencies used in solutions

Open

#1,290 创建于 2023年10月2日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Rust (32,954 star) (2,009 fork)batch import
enhancementgood first issuehelp wanted

描述

From https://github.com/google/comprehensive-rust/pull/1288#issuecomment-1743131185: the safe FFI wrapper solution does not actually work when you copy-paste it into a new Cargo project. The problem is that the unit tests rely on tempfile.

We need to fix this: I suggest adding some text to the solution which shows the cargo add commands to run. Alternatively, we could {{#include ...}} the Cargo.toml file — but I fear this will become messy since all solutions currently share a single Cargo.toml file. We could perhaps split them up further?

贡献者指南

技术栈
rust
领域
documentationdeveloper experiencetesting
议题类型
documentation
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust basicsCargo dev dependencies
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
Investigate the solution file at exercises/day 3/solutions afternoon.html and its Cargo.toml. The issue references PR #1288, which may contain discussion. Consider adding a note in the solution text listing the required `cargo add` commands for dev dependencies like tempfile. Alternatively, evaluate splitting the shared Cargo.toml to include per solution dev dependencies. Ensure the solution works when copy pasted into a new project.