google/closure-compiler

Jasmine Externs are out of Date

开放

#3,045 创建于 2018年8月6日

 (1 条评论) (0 个反应) (0 位负责人)Java (1,197 个派生)batch import
Externshelp wanted

仓库指标

星标
 (7,176 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

I've found that many Closure externs are out of date for Jasmine. Specifically, I see:

  • Many custom matcher types are missing, including:
    • CustomMatcherFactories
    • MatchersUtil
    • CustomEqualityTester
    • CustomMatcher
  • Jasmine's pretty print utility is missing (jasmine.pp())
  • Most matcher functions (toBe(), toEqual(), etc.) accept an optional string to use as an error message if the expectation fails. This is also missing.
  • Likely others...

Without these types, custom matchers are basically impossible. Would be great to see these types updated.

See: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jasmine/index.d.ts

贡献者指南