Polymer pass crashes when "properties" is not an object literal · google/closure-compiler#1950 | Good First Issue

(0 评论) (0 反应) (0 负责人)Java (1,197 fork)batch import

help wanted

仓库指标

Star: (7,176 star)
PR 合并指标: (平均合并 3天 4小时) (30 天内合并 1 个 PR)

描述

https://closure-compiler-debugger.appspot.com/#input0%3DPolymer(%257B%250A%2520%2520is%253A%2520'x-y'%252C%250A%2520%2520properties%253A%2520(function()%2520%257B%250A%2520%2520%2520%2520return%2520%257B%257D%253B%250A%2520%2520%257D)()%252C%250A%257D)%26input1%26conformanceConfig%26externs%3Dvar%2520Polymer%2520%253D%2520function(obj)%2520%257B%257D%250Avar%2520PolymerElement%2520%253D%2520function(obj)%2520%257B%257D%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26POLYMER_PASS%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1

We don't want to allow this, I don't think. But we should report an error rather than crashing :)

贡献者指南

研究方向: 在Closure Compiler中找到Polymer pass代码，并识别那些假设'properties'是对象字面量的代码路径。修改它以处理非对象字面量的值，并抛出一个描述性错误而不是崩溃。
技术栈: java
领域: frontend
议题类型: 缺陷
难度: 2
预计时间: 1-3 小时
活动状态: 活跃
清晰度: 清晰
前置要求: GitJava
新手友好度: 75