Use of cmake 3.6 feature with cmake_minimum_required (VERSION 2.8.12) · google/benchmark#603 | Good First Issue

(18 评论) (3 反应) (1 负责人)C++ (1,539 fork)batch import

enhancementhelp wanted

仓库指标

Star: (7,968 star)
PR 合并指标: (平均合并 4天 2小时) (30 天内合并 19 个 PR)

描述

https://github.com/google/benchmark/commit/e776aa0275e293707b6a0901e0e8d8a8a3679508 This commit adds list(FILTER SOURCE_FILES EXCLUDE REGEX "benchmark_main\\.cc") line to https://github.com/google/benchmark/blob/master/src/CMakeLists.txt. list(FILTER was introduced in CMake 3.6, however you script sets minimum required CMake version at 2.8.12.

贡献者指南

研究方向: 更新CMake最低要求版本，或将`list(FILTER ...)`替换为兼容的替代方案，如`foreach`和`list(APPEND)`。请参考提交e776aa0。
技术栈: cpp
领域: build system
议题类型: 缺陷
难度: 2
预计时间: 1 小时以内
活动状态: 活跃
清晰度: 清晰
前置要求: CMake basics
新手友好度: 70