google/benchmark

[FR] Allow modification of perf attributes

Open

#1,897 创建于 2025年1月6日

在 GitHub 查看
 (8 评论) (2 反应) (0 负责人)C++ (7,968 star) (1,539 fork)batch import
enhancementgood first issuehelp wanted

描述

Is your feature request related to a problem? Please describe.

I have a multi-threaded benchmark where I'd like the performance counters to only measure the main thread.

Describe the solution you'd like

Setting the inherit attribute to false instead of true before passing the struct to perf_event_open would solve my issue. Some sort of configuration option which allows me to set this would be ideal. Maybe this can be extended to other attributes as well instead of hardcoding them.

Describe alternatives you've considered

Currently, I have to set it to false and recompile google benchmark.

贡献者指南

技术栈
cpp
领域
performancebackend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
C++ basicsLinux perf events
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue requests allowing modification of perf event attr fields, specifically the 'inherit' attribute in src/perf counters.cc at line 151. Investigate how to expose a configuration option to set these attributes, possibly via command line flags or a struct passed to the benchmark. Check existing comments for any maintainer suggestions on acceptable design.