google-gemini/gemini-cli

test(a2a-server): migrate process.env to vi.stubEnv() per GEMINI.md conventions

Open

#19,826 创建于 2026年2月21日

在 GitHub 查看
 (8 评论) (0 反应) (1 负责人)TypeScript (103,992 star) (13,657 fork)batch import
Stalearea/platformgood first issuehelp wantedkind/bugkind/customer-issuepriority/p3status/bot-triaged

描述

Description

Per the testing conventions documented in GEMINI.md:

When testing code that depends on environment variables, use vi.stubEnv('NAME', 'value') in beforeEach and vi.unstubAllEnvs() in afterEach. Avoid modifying process.env directly as it can lead to test leakage and is less reliable.

Several test files in packages/a2a-server/ still use direct process.env manipulation:

  • src/commands/init.test.ts (1 direct assignment)
  • src/config/config.test.ts (~8 direct assignments/deletions)
  • src/http/app.test.ts (3 direct assignments/deletions)

Proposed fix

Replace all direct process.env writes and deletes with vi.stubEnv() / vi.unstubAllEnvs() following the pattern documented in GEMINI.md.

I'd be happy to submit a PR for this.

贡献者指南

技术栈
typescriptvitest
领域
testingbackend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
familiarity with GEMINI.md conventionsbasic understanding of Vitest
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Replace direct process.env assignments and deletions in the three test files (init.test.ts, config.test.ts, app.test.ts) with vi.stubEnv() in beforeEach and vi.unstubAllEnvs() in afterEach. Follow the pattern documented in GEMINI.md. No additional code changes are required.
test(a2a-server): migrate process.env to vi.stubEnv() per GEMINI.md conventions · google-gemini/gemini-cli#19826 | Good First Issue