x/tools/cmd/goyacc: bad code generated by goyacc for large grammars (more than 1000 non-terminals)

(3 条评论) (0 个反应) (0 位负责人)Go (19,008 个派生)batch import

BugReportNeedsInvestigationToolshelp wanted

仓库指标

星标: (133,883 个星标)
PR 合并指标: (30 天内没有已合并 PR)

描述

Go version

go version go1.26.1 darwin/arm64

Output of `go env` in your module/workspace:

AR='ar'
CC='cc'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='c++'
GCCGO='gccgo'
GO111MODULE=''
GOARCH='arm64'
GOARM64='v8.0'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/Users/deepak/Library/Caches/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV='/Users/deepak/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/yw/mq1pwdbx3gd9077rsc65x7jw0000gn/T/go-build4184327577=/tmp/go-build -gno-record-gcc-switches -fno-common'
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMOD='/Users/deepak/src/varonis/dev.azure.com/VaronisIO/DA Cloud/pg-parser/go.mod'
GOMODCACHE='/Users/deepak/go/pkg/mod'
GONOPROXY='github.com/cyralinc/*,dev.azure.com/VaronisIO/*,github.com/lestrrat-go/*'
GONOSUMDB='github.com/cyralinc/*,dev.azure.com/VaronisIO/*'
GOOS='darwin'
GOPATH='/Users/deepak/go'
GOPRIVATE='github.com/cyralinc/*,dev.azure.com/VaronisIO/*'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/opt/homebrew/Cellar/go/1.26.1/libexec'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/deepak/Library/Application Support/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/opt/homebrew/Cellar/go/1.26.1/libexec/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.26.1'
GOWORK=''

What did you do?

Run goyacc on a large grammar

What did you see happen?

When the number of non-terminals in the grammar is < 1000, the generated code behaves fine but the generated code fails to parse even simple inputs when the number of non-terminals is >= 1000. I confirmed that changing the value of the constant NOMORE to something like -1000000 from -1000 fixes the issue. This appears to be a sentinel value which should have a larger absolute value than the number of non-terminals in the grammar.

The number of states etc., were all within limits of the other defined constant values in the code.

What did you expect to see?

The generated code should work fine for a large number of non-terminal symbols in the grammar. 1000 definitely is not a very large number.

贡献者指南

研究方向: The issue identifies that the constant NOMORE in goyacc source code has a value of 1000, which fails when grammars have 1000 or more non terminals. The fix involves increasing the absolute value of NOMORE or making it dynamically computed based on grammar size. The relevant file is likely in x/tools/cmd/goyacc/. Maintainers should review the constant usage and decide on a safe sentinel value.
技术栈: go
领域: tooling
议题类型: 缺陷
难度: 3
预计时间: 1 小时以内
活动状态: 新近可参与
清晰度: 清晰
前置要求: basic Go knowledgefamiliarity with goyacc
新手友好度: 90