golang/go

x/tools/internal/typesinternal: FileQualifier needs to add imports, and reject unnameable types

Open

#75,604 创建于 2025年9月25日

在 GitHub 查看
 (8 评论) (0 反应) (1 负责人)Go (133,883 star) (19,008 fork)batch import
NeedsFixRefactoringToolshelp wanted

描述

The job of FileQualifier is to help TypeString print types in valid Go syntax, respecting the local lexical environment and the file's set of existing imports. However, in general this may require (a) adding new imports for types belonging to packages that are not currently imported and (b) reporting that the task cannot be completed because one or more types are members of another package and are inaccessible either because they are unexported or because that package is internal relative to this one.

The task of this issue is to augment FileQualifier to accumulate a list of import edits, and an error when it sees a type it cannot print. This should fix a number of bugs across all our refactoring tools. It could also use some good tests.

贡献者指南

技术栈
go
领域
developer experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingUnderstanding of Go type systemFamiliarity with x/tools internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue requires modifying the FileQualifier type in the x/tools/internal/typesinternal package. The goal is to accumulate import edits and report errors when types cannot be printed (e.g., unexported or internal packages). Review the current implementation of FileQualifier in that package, understand how TypeString interacts with it, and then implement the two new capabilities. Add comprehensive tests for various scenarios, including importing new packages and handling unnameable types. The linked PRs or comments in the issue may provide additional context.