golang/go

x/tools/go/analysis/passes/modernize: minmax: suggest deletion of redundant min and max functions

Open

#75,589 创建于 2025年9月24日

在 GitHub 查看
 (13 评论) (1 反应) (0 负责人)Go (133,883 star) (19,008 fork)batch import
NeedsInvestigationRefactoringToolshelp wanted

描述

Proposal Details

I proposal to add a checker to check whether user has impl a max/min instead of builtin max/min. And suggest user to replace with builtin max/min. search

language:go "func min"

in github with get about 142k result in code.

贡献者指南

技术栈
go
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Go programmingGo analysis frameworkAST manipulation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Review the existing checkers in the modernize pass to understand the pattern for suggesting replacements. Analyze the Go AST for function declarations named 'min' or 'max' that have the same signature as built in min/max. Consider edge cases like different return types, variadic versions, or use in older Go versions. Check comments in the issue for any additional constraints or examples.
x/tools/go/analysis/passes/modernize: minmax: suggest deletion of redundant min and max functions · golang/go#75589 | Good First Issue