cmd/vet: warn about unused struct or array, ignoring assignment to field or element · golang/go#449

2009-12-22T02:14:21.000Z

by **RyanneDolan**: What steps will reproduce the problem? v := new(struct{i int}) v.i = 1 What is the expected output? What do you see instead? Should get "v declared and not used" error. Instead, compiles fine. What is your $GOOS? $GOARCH? linux/386 Which revision are you using? (hg identify) 54392bd03d06 tip Please provide any additional information below. The dot operator should mark its left operand as "used" only when it appears on the RHS. a = 1 // 'a' is not marked as used (CORRECT) v.i = 1 // 'v' is marked as used (WRONG) a = v.i // 'v' is marked as used (CORRECT) This bug is important to fix for consistency, and because it confuses new programmers who might expect reference semantics: for _,v := range arr {v.i = 1} // doesn't do anything Mentioned here: http://groups.google.com/group/golang- nuts/browse_thread/thread/342fe61c78916496/fbb57f693f1aca72

(9 评论) (0 反应) (0 负责人)Go (19,008 fork)batch import

AnalysisNeedsFixhelp wanted

仓库指标

Star: (133,883 star)
PR 合并指标: (30 天内没有已合并 PR)

描述

by RyanneDolan:

贡献者指南

研究方向: 检查cmd/vet工具的代码，找到将分配给结构体字段或数组元素的操作数标记为使用的位置，并将其修改为仅当表达式出现在右侧时才标记为使用。
技术栈: go
领域: backend
议题类型: 缺陷
难度: 2
预计时间: 1-3 小时
活动状态: 活跃
清晰度: 清晰
前置要求: Go
新手友好度: 60

仓库指标

描述

贡献者指南

每天在邮箱收到新鲜 Easy issues。