golang/go

x/tools/gopls: consider using &S form instead of *S for pointer type struct field autocompletion

开放

#39,227 创建于 2020年5月23日

 (5 条评论) (0 个反应) (0 位负责人)Go (19,008 个派生)batch import
NeedsDecisionToolsgoplshelp wanted

仓库指标

星标
 (133,883 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Currently autocompletion for a struct field uses the field's type as the placeholder text. For example,

type F struct {...}
type S struct {
   Field *F
}

The autocompletion for the Field will return "newText":"Field: ${1:*F},". gopls uses the type info for placeholder text, so I don't think the choice is incorrect nor invalid.

But if the suggestion used &F instead, it would be more convenient when users want to use composite literals. Especially, if the type name is long to type, reusing what's already in the placeholder will save many keystrokes.

(Based on https://github.com/golang/vscode-go/issues/85)

贡献者指南