golang/go
cmd/vet: govet sometimes wrong about whether a context gets cancelled
开放
#29,587 创建于 2019年1月6日
AnalysisNeedsInvestigationhelp wanted
仓库指标
- 星标
- (133,883 个星标)
- PR 合并指标
- (30 天内没有已合并 PR)
描述
What version of Go are you using (go version)?
Not sure, it's a toolchain. Most likely 1.11.
Does this issue reproduce with the latest release?
Yes, as of 1.12beta.
What operating system and processor architecture are you using (go env)?
No idea, govet runs remotely on a language server.
What did you do?
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
if true {
// This makes govet think that the child context never gets cancelled,
// when, in fact, it is cancelled by the parent's cancel().
ctx, _ = context.WithTimeout(ctx, time.Second)
}
What did you expect to see?
govet should not claim that the child context leaks. (If it's a style question, it should be in the linter, not govet.)
What did you see instead?
govet incorrectly thinks the child context does not get cancelled.