golang/go

go/ast: trailing func comments mishandled in CommentMap

Open

#22,371 创建于 2017年10月20日

在 GitHub 查看
 (2 评论) (2 反应) (0 负责人)Go (19,008 fork)batch import
NeedsFixhelp wanted

仓库指标

Star
 (133,883 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Working example: https://play.golang.org/p/TlsDxVbGow

Prints: g: "trailing comment in f\n"

Seems like the correct output should either be nothing (if it is associated with _ = x), or f: "trailing comment in f\n".

What's currently happening is that the "_ = x" in func f is the most recent "important" node when we encounter the comment. Since the comment isn't on the line immediately following "_ = x", it doesn't get associated with it. We don't look further up the "important nodes" stack to notice that it's within the bounds of f. Instead, we just give up and associate it with g.

/cc @griesemer

贡献者指南