NeedsFixhelp wanted
仓库指标
- Star
- (133,883 star)
- PR 合并指标
- (30 天内没有已合并 PR)
描述
We previously debated whether the Transport should send GOAWAY frames on shutdown, but couldn't think of a useful reason why.
The spec does say:
When either endpoint chooses to close the transport-layer TCP connection, the terminating endpoint SHOULD first send a GOAWAY (Section 6.8) frame so that both endpoints can reliably determine whether previously sent frames have been processed and gracefully complete or terminate any necessary remaining tasks.
Or code is like:
// TODO: do clients send GOAWAY too? maybe? Just Close:
cc.tconn.Close()
But I'm still not quite sure why a server would care.
/cc @mnot @tombergan