golang/go

test: doesn't use GO_GCFLAGS for tests

开放

#18,222 创建于 2016年12月7日

 (2 条评论) (0 个反应) (0 位负责人)Go (19,008 个派生)batch import
BuildersNeedsFixTestinghelp wanted

仓库指标

星标
 (133,883 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

GO_GCFLAGS only affects the compiler that is invoked directly by the dist tool (I think). The compiler invoked by test/run.go doesn't have its command line modified by GO_GCFLAGS. So all of the tests in test/ aren't actually testing what we think they are testing on the modified builders like noopt and ssacheck.

Maybe this is unfixable as a some of the tests in test/ provide their own flags to the compiler. But it surprised me that the ssacheck checks weren't actually running on the ssacheck builder in the test directory.

Maybe there's some way to propagate GO_GCFLAGS that makes sense.

See https://go-review.googlesource.com/c/33909/ for a hack I needed to make this work for randomized value order testing.

@bradfitz @cherrymui @dr2chase

贡献者指南