godaddy/kubernetes-client

Get pods via LabelSelctor

Open

#144 创建于 2017年8月31日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)JavaScript (954 star) (206 fork)batch import
help wantedrequest for example

描述

When trying to get pods via label selector I get all pods returned in the name space. core.ns.po.get({ qs: { labelSelector: 'mylabel=thelabel' } }, (err, results) = > { console.log(results); });

Not sure what the correct method would be for getting pods based on label selectors. Looking through the code base, I noticed the .get on pods will not accept the label selector. https://github.com/godaddy/kubernetes-client/blob/master/lib/replicationcontrollers.js#L46

Am I overlooking something simple?

贡献者指南

技术栈
javascriptnodejsrest api
领域
apibackend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.js basicsKubernetes conceptsREST API basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Investigate the current state of the kubernetes client library, focusing on the pods endpoint. The issue reports that the get method on pods does not handle the labelSelector query parameter. Look at lib/replicationcontrollers.js as referenced, and the main API code for pods. Determine if this bug is still present in the latest version and if not, what the correct usage is. If it remains, implement support for labelSelector by adding it to the query string options.