go-sql-driver/mysql

NullTime does not use DSN location

Open

#568 创建于 2017年4月14日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Go (9,946 star) (1,789 fork)batch import
help wanted

描述

Issue description

The NullTime helper is hardcoded to parse in location time.UTC but should really use the location set in the DSN (which defaults to UTC). Maybe you could have a variable in the utils timeZone that gets set during DSN Parsing?

贡献者指南

技术栈
go
领域
backenddatabase
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go basicsdatabase/sql packageMySQL driver DSN parsing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Review the DSN parsing logic in the MySQL driver to see how location is handled (likely in a function like `parseDSN`). Then examine the NullTime implementation in `utils.go` to understand why it currently hardcodes UTC. The fix involves using a stored location variable instead of UTC, ensuring it is set during DSN parsing. Check existing comments or related issues for any prior discussion.
NullTime does not use DSN location · go-sql-driver/mysql#568 | Good First Issue