go-kit/kit

[metrics/cloudwatch] Feature request: ability to publish a sample of metrics for histograms

Open

#980 创建于 2020年5月7日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Go (27,422 star) (2,446 fork)batch import
enhancementhelp wanted

描述

The cloudwatch metrics exporter currently has support for publishing histograms as a set of metrics of the histogram quantiles (e.g. p50, p90, p95, p99).

What I would like to do, is have the ability to instead publish a random sample of the recorded histogram values and let CloudWatch do the bucketing. This is because I have multiple instances that I would like to publish the same metric for without labeling them with a label unique to the instance. If there are less than 150 observations (the max for an individual PutMetricsData request to AWS), they would all be sent.

I pushed some changes up to demonstrate what I mean: https://github.com/go-kit/kit/compare/master...jszwedko:metrics/cloudwatch/add-ability-to-publish-histogram-values?expand=1 . If you all are amenable to this change, I can continue implementing it and open a PR.

Thanks!

贡献者指南

技术栈
go
领域
observabilitycloud
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingAWS CloudWatch knowledgego kit metrics libraryhistogram concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine the linked branch at https://github.com/go kit/kit/compare/master...jszwedko:metrics/cloudwatch/add ability to publish histogram values?expand=1 to see the proposed implementation. Focus on the cloudwatch metrics exporter in the repository (path: metrics/cloudwatch). Understand how histograms are currently published as quantiles and how the suggested change allows publishing raw samples. Review the AWS CloudWatch PutMetricsData API limits (max 150 values per request) and consider how to handle cases with more observations. Check existing tests and documentation for the cloudwatch package to ensure new functionality aligns with the project's patterns.