go-kit/kit

transport/http ServerFinalizer should accept error for better logging support

Open

#807 创建于 2018年12月1日

在 GitHub 查看
 (14 评论) (2 反应) (0 负责人)Go (27,422 star) (2,446 fork)batch import
enhancementhelp wanted

描述

We have three systems where logs are sent: our internal ELK stack, NewRelic and Airbrake. Some of our endpoints send errors to all of this systems, some endpoints send errors to only one of it.

We want log entries to have both error message and http status code. And also some http request context (uri, method, user-agent, ip...)

The only place which has access to both error and http status is ServerErrorEncoder. But since different endpoints need different sets of log outputs, we would have to create multiple error encoders just for sake of logging. Also, ServerErrorEncoder is not a good place for logging, because we would like it to do only one job - encode errors.

ServerFinalizer seems to be a great place to send logs, but there is no access to actual error message.

贡献者指南

技术栈
go
领域
backendobservability
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programminggo kit basicsHTTP transport concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Examine the `ServerFinalizer` type in `transport/http/server.go` to understand its current signature and usage. Review comments in the issue about logging in `ServerErrorEncoder`. The fix involves adding an `error` parameter to `ServerFinalizer` and updating all implementations. Look for any linked PRs or maintainer responses in the issue comments for additional context.
transport/http ServerFinalizer should accept error for better logging support · go-kit/kit#807 | Good First Issue