go-kit/kit

SD - Registrator error handling

Open

#780 创建于 2018年10月23日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Go (27,422 star) (2,446 fork)batch import
enhancementhelp wantednewbie friendly

描述

Is there any reason for not returning any error on the registration of a service? https://github.com/go-kit/kit/blob/ec0cc13a9b00d1214c9b7ae63d7b750626b54c6d/sd/registrar.go#L11

From my point of view, if a service doesn't manage to correctly register, then it might be nice to retry later. Binding to events to watch if you're correctly registered seems overkilled compared to just checking this error.

What are your thoughts?

贡献者指南

技术栈
go
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingService discovery concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the `Register` method in `sd/registrar.go` (line 11) and all implementations of the `Registrator` interface. The issue suggests adding an error return. Determine if any existing implementations already have error handling logic that could be lifted. Also consider the single comment on the issue for additional context. Write a test case for the new behavior.