globalizejs/globalize

Date: Handle undefined skeleton

Open

#469 创建于 2015年7月23日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (4,759 star) (645 fork)batch import
date modulehelp wantedquick change

描述

When using an undefined skeleton, e.g., {skeleton: '<anything here that doesn't exist>'} https://github.com/jquery/globalize/blob/master/src/date.js#L64 returns undefined, which in turn is passed as the expanded-pattern to the formatter, which in turn tries to recognize u and fails.

Originally raised on #455.

贡献者指南

技术栈
javascript
领域
localizationinternationalization
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
familiarity with JavaScriptunderstanding of date formatting
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue is in the Date module of the Globalize library. The bug occurs at src/date.js line 64 when an undefined skeleton is passed. The value `undefined` is passed to the formatter, causing a failure. A fix would involve adding a check for undefined before using the skeleton. Refer to the original issue #455 for more context. The repository is a JavaScript project for internationalization using CLDR data.