globalizejs/globalize

Code cleanup: Can we remove the nested functions pattern of util.assertFns?

Open

#361 创建于 2014年12月8日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (4,759 star) (645 fork)batch import
help wantedquick change

描述

Ref: https://github.com/jquery/globalize/pull/351/files#r21450932

util.assertCurrencyParameter( assert, "currency", function( invalidValue ) {
 return function() {
    Globalize.currencyFormatter( invalidValue );
  };
});

@jzaefferer

I guess we've discussed this before as well, still doesn't make much sense: Why does this test have to return two nested functions?

@rxaviers

Yeap, we have discussed about this and it was clear this was needed. Although, I also believe this could be simplified.

贡献者指南

技术栈
javascript
领域
localizationtesting
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaScriptUnderstanding of Globalize test utilities
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Review the linked pull request #351 to understand the current nested function pattern. Then, search the codebase for uses of util.assertFns and similar patterns. Propose a refactored version that removes the nested functions while preserving functionality. Check for any existing tests that depend on the current shape.