globalizejs/globalize

Code cleanup: Simplify tests util functions that passes assert as a parameter

Open

#359 创建于 2014年12月8日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (4,759 star) (645 fork)batch import
help wantedquick change

描述

Ref: https://github.com/jquery/globalize/pull/351/files#r21450909

util.assertParameterPresence( assert, "currency", function() {
  Globalize.currencyFormatter();
});

@jzaefferer

I brought this up before, might be worth another try. Can this be changed to the below?

assert.parameterPresence( "currency", ... );

The same applies to any other calls that pass assert as a parameter

@rxaviers

Sorry if I missed it. But, I don't remember such comment. If you say it's better overloading assert, it shall be. Will be tracked as a separate issue #359

贡献者指南

技术栈
javascript
领域
testingdeveloper experience
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of JavaScript testing practices
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue proposes refactoring test utility calls throughout the test suite to avoid passing the assert object as a parameter. Instead, the assert methods should be called directly on the assert object. The refactoring pattern is shown in the issue: change from `util.assertParameterPresence(assert, ...)` to `assert.parameterPresence(...)`. This change needs to be applied to all similar calls in the test files. Since the issue is old and no linked PRs exist, the contributor should search the repository's test files (likely under the 'test' directory) for occurrences of functions that take 'assert' as a first parameter and update them accordingly. The maintainer's comment suggests this is a mechanical change that improves code readability.