glideapps/quicktype

Detect and properly handle recursive types

Open

#273 创建于 2017年11月14日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)TypeScript (10,867 star) (968 fork)batch import
Elmbuggood first issue

描述

Recursive types can result even from JSON input (via merging of similar types - see the recursive.json sample), so every backend either needs to be able to handle them, or signal that it can't. Some languages, like Swift, require an option to handle them, so we'd either have to turn that option on when recursive types are involved, or only allow merging in case the option is on. It would be even better if we had an analysis that could detect not only whether there are recursive types, but which types are involved in the recursion, which would allow us to generate class types only for them in Swift, for example, or emit forward declarations in C++.

贡献者指南

技术栈
typescript
领域
tooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
over 1 week
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understand recursive type definitionsFamiliarity with quicktype's codebaseKnowledge of type generation backends
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
15
研究方向
Examine the existing type inference logic in src/TypeGraph.ts and src/TypeBuilder.ts. Understand how merging works and where recursive types arise. Review the Swift backend (src/Swift.ts) to see how the 'recursive' option is handled. Propose a strategy to detect recursion and either generate class types for Swift or forward declarations for C++. Discuss with maintainers on the issue thread.