glideapps/quicktype

python: invalid code due to comments starting or ending with double quotes

Open

#1,239 创建于 2019年5月23日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (10,867 star) (968 fork)batch import
Pythonbuggood first issue

描述

when generating python code, the generated syntax becomes invalid if there are comments (i.e. "description" fields in the JSON schema) that start or end with double quotes

Example

for the JSON schema fragment:

"properties": {
  "type": {
    "description": "type is \"output\"",
    "minLength": 1,
    "oneOf": [
	  {
	    "$ref": "#/definitions/MessageType"
	  }
    ]
  },

the generated (invalid) python 3.7 code fragment is

"""type is "output""""
type: MessageType

Solution

the generator for python should check the first and last character of a documentation-comment (i.e. the "description" field value) -- and if this is the case, the emitted code should "escape" these characters (e.g. prepend/append a newline or space character)

贡献者指南

python: invalid code due to comments starting or ending with double quotes · glideapps/quicktype#1239 | Good First Issue