gitpoint/git-point

Icons and the sort of issue events

Open

#868 创建于 2019年1月23日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (4,684 star) (837 fork)batch import
:bug: bughelp wanted

描述

  • Not every icon is in the center.
    • We need test function marginLeftForIconName in issue-event-list-item.component.js for every icons and update.
  • The sort doesn't always obey created time. Maybe caused by #848.
    • Some items have invalid created_at value.

贡献者指南

技术栈
javascriptreact native
领域
frontendmobiletesting
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
React NativeJavaScriptGitPoint codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
First, examine `issue event list item.component.js` to find the `marginLeftForIconName` function and ensure it correctly centers all icons. Write a test for it. Second, investigate the sorting logic in the same component or related files; check the `created at` values from the API and ensure they are valid timestamps. The issue mentions PR #848 may have caused the sorting problem, so review that PR's changes to understand the impact. Finally, verify that the sorting order respects chronological order.