ggml-org/whisper.cpp

Streaming to file leads to "duplicates"

开放

#1,056 创建于 2023年6月27日

 (3 条评论) (0 个反应) (0 位负责人)C++ (6,072 个派生)batch import
enhancementgood first issue

仓库指标

星标
 (52,942 个星标)
PR 合并指标
 (平均合并 5天 20小时) (30 天内合并 36 个 PR)

描述

Hi all,

First of all, amazing work on this project. I'm really excited about what you're doing.

There's something I noticed about the way the ./stream works with the file parameter. I believe that for the stdout, it's only printing to a newline every n_new_line, and it would otherwise use a carriage return to overwrite the last line. This works nicely for stdout, but with the file output parameter, it's printed as a new line for every iteration.

I think this is buggy because the resulting text file has a bunch of duplicate lines most of the time, and it's difficult to parse out later. I'm guessing that this was written this way because you can't write carriage returns to a file and have it clear the last line like you can with stdout, but I think it would be a good compromise to only write to file on every n_new_line.

What do you think?

贡献者指南