ggml-org/llama.cpp

llama : integer type consistency in `llama.h`

开放

#4,574 创建于 2023年12月21日

 (4 条评论) (4 个反应) (0 位负责人)C++ (21,822 个派生)batch import
enhancementgood first issuerefactoringroadmap

仓库指标

星标
 (124,374 个星标)
PR 合并指标
 (平均合并 6天 8小时) (30 天内合并 389 个 PR)

描述

Feature Description

llama.h should prefer to use sized (always) + signed (mostly) integers.

Motivation

The integer types in llama.h right now are.

Count Type
33 int
10 int32_t
24 uint32_t
2 int64_t
2 uint64_t

In #4540 there was a discussion around preferences for integer types on new methods.

Avoiding int makes cross platform code simpler at essentially no cost. Signed makes arithmetic simpler at the cost of some bits if you need something large.

Possible Implementation

  1. Change all int's to int32_t
  2. As code changes try to prefer signed integers.

We could also do some higher-impact things, but I'd take the lower-impact slower changes over a large find-and-replace.

贡献者指南