gfx-rs/wgpu

[naga] `Arena` could use a `take` method

Open

#6,509 创建于 2024年11月9日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Rust (9,290 star) (703 fork)batch import
good first issuekind: refactornaga

描述

There are a few places in Naga where we actually clone an Arena, in situations where a take would be better. For example, naga::front::wgsl::lower::Lowerer::lower clones the diagnostic filters array.

贡献者指南

技术栈
rust
领域
backendperformance
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rustknowledge of Arena pattern
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the Arena type in Naga to determine if a take method can be added. Look at the usage in naga::front::wgsl::lower::Lowerer::lower and other places where Arena is cloned. Implement a take method that removes and returns data, and replace clones with take calls. Ensure all tests pass.
[naga] `Arena` could use a `take` method · gfx-rs/wgpu#6509 | Good First Issue