gfx-rs/wgpu

WGPU_TRACE file from Firefox Nightly is missing final close-bracket

Open

#1,620 创建于 2021年7月9日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)Rust (9,290 star) (703 fork)batch import
good first issuehelp requiredtype: bug

描述

Description When running a wasm binary on Firefox Nightly with tracing enabled (as per this, the generated trace.ron file is missing a final ]. As a result, the player fails with an "unexpected EOF" error. Manually adding the ] allows the player to work.

Compared to tracing the same program compiled natively, it's also missing various DestroyBindGroup/DestroyBuffer etc. calls, which might be related to the final ] being missing.

Platform MacOS 11.4, wgpu latest (e27fbb821bb3397069d0a82ef8da8e151feb0647), Firefox Nightly 2021-07-07.

贡献者指南

技术栈
rustwasm
领域
toolingtesting
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Rustwgpu tracing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the trace file generation code in wgpu to ensure the closing bracket is written. Compare the native trace generation with the wasm path. Look at the Player's RON parsing. Possibly related to missing Destroy calls; check if they are being emitted and not flushed before EOF.