getredash/redash

Google Spreadsheets worksheet by title cleanup/refactor

Open

#6,409 创建于 2023年8月31日

在 GitHub 查看
 (5 评论) (3 反应) (1 负责人)Python (24,845 star) (4,236 fork)batch import
enhancementgood first issue

描述

In #5334 , I left a few comments about future work on the "fetch worksheet by title" functionality for the google spreadsheets query runner. We should address those, namely:

  • don't use mixed-type variables
  • allow for non-quoted worksheet titles (single word)
  • verify 0/1 indexing of worksheet numbers, and add comment if it differs

贡献者指南

技术栈
python
领域
backendapi
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic Python knowledgeFamiliarity with Redash plugin structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Review the comments and code changes in PR #5334 to understand the existing implementation for fetching worksheet by title. Check the mixed type variables and decide on a consistent type. Look at how worksheet titles are currently quoted; extend support for non quoted single word titles. Verify the 0/1 indexing of worksheet numbers by examining the Google Sheets API documentation and the current usage in the codebase, then add clarifying comments.
Google Spreadsheets worksheet by title cleanup/refactor · getredash/redash#6409 | Good First Issue