getredash/redash

Don't show simple results API usage examples for parameterized queries

Open

#3,815 创建于 2019年5月20日

在 GitHub 查看
 (7 评论) (1 反应) (0 负责人)Python (24,845 star) (4,236 fork)batch import
FrontendUXhelp wanted

描述

When you open the API Key dialog for a query, we show results API usage examples:

image

These examples will not work in the case of a parameterized query. We should at least replace the examples with a message explaining this or preferably show something along the lines of @rauchy's comment.

贡献者指南

技术栈
pythonjavascriptrest api
领域
apidocumentation
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with Redash's frontend codeUnderstanding of API key dialogKnowledge of parameterized queries
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Review the frontend code for the API key dialog, likely in a React component. Identify where the results API usage examples are rendered. Determine how to check if the query is parameterized. Modify the component to hide the examples and show a message for parameterized queries, following the suggestion in @rauchy's comment.