getredash/redash

Visualization map (markers) doesn't reset with data

Open

#3,313 创建于 2019年1月20日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Python (24,845 star) (4,236 fork)batch import
BugFrontendhelp wanted

描述

Issue Summary

When I use a query filter to narrow down some geo data, the map view doesn't reset to line up with the map markers currently being displayed. The viewbox on the map stays wrapped around the first set of data (even after it disappears). So I have to zoom and drag the map manually to see the data.

Steps to Reproduce

  1. Load this data set from gh and then manipulate it with the Query Results data source.
  2. Use a query filter to limit the data by state name
  3. Make a map (markers) visualization
  4. Change the query filter
  5. Observe that the the map visualization doesn't update with a different data set.

I would expect the map to update its viewport to wrap around the most recently rendered coordiantes.

Technical details:

  • Redash Version: 431d6fa
  • Browser/OS: Chrome 71
  • How did you install Redash: Saas Product

贡献者指南

技术栈
pythonjavascriptreact
领域
frontenddata
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptReactMap libraryRedash development setup
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Review the map visualization component in the Redash frontend codebase (likely under `client/app/components/visualizations/map/`). Understand how the viewport is set initially when data loads. Identify the logic that updates the viewport when data changes and ensure it resets the viewbox to fit new markers. Check if there is a method to fit bounds on data update. No linked PRs or comments exist.